Quoting Fauzaan

Disliked

{quote} Done {quote} Done {quote} Done {quote} Done {quote} Is this a new parameter? Is it the duration of the trade? or ...? {quote} These three i havnt included yet Im hoping there are some other people who can code in here as well who can add into this, and so im posting the mq4 file {file}

Ignored

bool swingCheck(Modes value,int candles)
{
if (value == HH)
{
if (High[candles+1] > High[candles+2])
{
return(true);
}
 
}
if (value == LL)
{
if (Low[candles+1] < Low[candles+2])
{
return(true);
}
 
}
 
if (value == HL)
{
if (Low[candles+1] > Low[candles+2])
{
return(true);
}
 
}
 
if (value == LH)
{
if (High[candles+1] < High[candles+2])
{
return(true);
}
 
}
return(false);
}

EA should not compare two bars, but instead compare 3 swings (for example: comparing LowestLow and HighestHigh).
double LowestLow = Low[iLowest(NULL, 0, MODE_LOW, 10, 1)]; //from the first bar to the 10th bar
 
double LowestLow2 = Low[iLowest(NULL, 0, MODE_LOW, 10, 10)]; //from the 10th to the 19th bar
 
double HighestHigh = High[iHighest( NULL, 0, MODE_HIGH, 10, 1 )];
//and now check if LowestLow occurs after HighestHigh
int checkSwingType()
{
if(LowestLow3 > LowestLow2 > LowestLow1){ return 1; //1 means: LL (lower low)
if(LowestLow3 > LowestLow2 < LowestLow1){ return 2; //2 means: HL (higher low)
if(HighestHigh3 < HighestHigh2 < HighestHigh1){ return 3; //3 means: HH (a new higher high occured)
if(HighestHigh3 < HighestHigh2 > HighestHigh1){ return 4; //4 means: LH (a new lower high occured)
}; // but the zigzag indicator still does a much better job to identify LL, HL, HH and LH (see last screenshot of zigzag).

Quoting Fauzaan

Disliked

{quote} Done {quote} Done {quote} Done {quote} Done {quote} Is this a new parameter? Is it the duration of the trade? or ...? {quote} These three i havnt included yet Im hoping there are some other people who can code in here as well who can add into this, and so im posting the mq4 file {file}

Ignored